DANCE WITH JAVA

开发出高质量的系统

常用链接

统计

积分与排名

好友之家

最新评论

使用SimpleDateFormat必须注意的问题

在使用SimpleDateFormat的经常会有一些错误的用法,例如如下方式:
public class TestDateFormat{
     
private SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd");
     
public void method1(){
         sdf.format(
new Date());
     }

     
public void method2(){
         sdf.format(
new Date());
     }

 )
为了渐少new 的次数而把SimpleDateFormat做成成员或者静态成员,但这样的做法是隐含着错误的,是不
 安全的。如下给出证明:
 import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.HashMap;
import java.util.Map;


public class TestDateFormat{
    
private SimpleDateFormat sdf ;
    
public static void main(String[] args) {
        SimpleDateFormat sdf
= new SimpleDateFormat("yyyy-MM-dd");
        Date date1 
= new Date();
        Date date2 
= new Date(date1.getTime()+1000*60*60*24);
        System.out.println(date1);
        System.out.println(date2);
        Thread thread1 
= new Thread(new Thread1(sdf,date1));
        thread1.start();
        Thread thread2 
= new Thread(new Thread2(sdf,date2));
        thread2.start();
    }

    
}

class Thread1 implements Runnable{
    
private SimpleDateFormat sdf;
    
private Date date;
    
public Thread1(SimpleDateFormat sdf,Date date){
        
this.sdf = sdf;
        
this.date = date;
    }

    
public void run() {
        
for(;;){
            String strDate 
= sdf.format(date);
            
if("2007-02-27".equals(strDate)){
                System.err.println(
"Error: date1="+strDate);
                System.exit(
0);
            }

        }

    }

}

class Thread2 implements Runnable{
    
private SimpleDateFormat sdf;
    
private Date date;
    
public Thread2(SimpleDateFormat sdf,Date date){
        
this.sdf = sdf;
        
this.date = date;
    }

    
public void run() {
        
for(;;){
            String strDate 
= sdf.format(date);
            
if("2007-02-26".equals(strDate)){
                System.err.println(
"Error: date1="+strDate);
                System.exit(
0);
            }

        }

    }

}

很快,基本几十次就会出现错误。错误原因:
 因为SimpleDateFormat处理复杂,Jdk的实现中使用了成员变量来传递参数,这个就造成在多线程的时候
 会出现错误。上边的程序证明了这个问题。
 
 再看看SimpleDateFormat的Jdk 的Source,有这么一段注释,说明它不是线程安全的。
 Date formats are not synchronized.
 * It is recommended to create separate format instances for each thread.
 * If multiple threads access a format concurrently, it must be synchronized
 
 继续看看Sun自己的网站上。在sun的bug database中
 Bug ID:  4228335  讲的就是这个问题。
 SimpleDateFormat is not threadsafe (one more try)
 其中有这么几段话值得关注:
 1,
 Aside from the obvious, there are two reasons why this fix should be made:
- The documentation for DateFormat states that a DateFormat object should be used
multiple times, implying that construction is expensive.  Furthermore,
 no mention is made of SimpleDateFormat's lack of thread-safety. 
 Since for most applications the date formats remain constant,
 it is very easy to conclude that DateFormats should be application globals.
 But SimpleDateFormat produces incorrect results when used in this way.
- Bug 4101500, a similar problem with NumberFormat, was fixed.

建议修改这个问题,而且NumberFormat已经修改,解决了这个问题。简单测试了一下NumberFormat确是不出错

2,
Use of a cloned Calendar object in format(), as suggested in JDC comments,
slows down the execution 30-50%. And it potentially affects footprint because
of cloned objects. Another approach would be to have a Calendar instance per
thread. However, this approach will cause problems at the API semantic level due
to the get/setCalendar methods.
这一段解释了为什么没修改这个问题,一个是保持API不变,另一个是因为Clone比new慢,会损失效率
关于clone与new的快慢,看这里http://www.blogjava.net/dreamstone/archive/2007/02/26/100761.html

其它的还有好多,感兴趣的自己看看吧。

结论:每次使用它的时候现new,或者用一个同步函数把new好的包装起来使用吧。

posted on 2007-02-26 16:03 dreamstone 阅读(2862) 评论(0)  编辑  收藏 所属分类: jdk相关


只有注册用户登录后才能发表评论。


网站导航: